Fix create-release crash when no PRs exist#30
Merged
Conversation
- Add `|| true` to grep pipeline so it doesn't fail with exit 1 when no PR references (#123) are found in commit messages - Simplify GH_TOKEN expression to avoid secrets in comparisons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grepin the PR collection pipeline exits with code 1 when no#123-style references are found in commit messages, which crashes the script underset -euo pipefail|| trueto the grep pipeline so it gracefully handles commits without PR references (e.g. direct pushes to main)GH_TOKENenv expressionTest plan
🤖 Generated with Claude Code